#138 — Provide price values with currencies

Repo: Twill-AI/twill-llm-engine State: closed | Status: done Assignee: meliascosta

Created: 2024-09-24 · Updated: 2024-11-04

Description

Caused by https://twill-network.slack.com/archives/C06UCQP1BFC/p1727087760427069

If open https://ca-staging-twill-facade-eastus.happystone-888ee9bf.eastus.azurecontainerapps.io/api/v1/llmchats/56/items?limit=10&include_sources=false&include_widgets=true for user@twillpayments.com (in https://ca-staging-twill-facade-eastus.happystone-888ee9bf.eastus.azurecontainerapps.io/docs#/llmchats/get_llmchat_items_api_v1_llmchats__llmchat_id__items_get) and find 506 item with “type”: “ChatResponseEcharts” then it would show:

"headers\":[\"item_description\",\"item_price\",\"issue_date\"],\"rows\":[[\"Bar Bingo 08/07, 08/14, 08/21, 08/28\",540,\"2024-09-02 00:00:00\"] ...

I.e. price is provided without currency. If look at data then bill_line_item table doesn’t contain currency but relevant “bill” table has “currency_code” column (and bill_line_item has FK to the parent bill). So currency may be tracked.

AC:

  • All “price” values are provided with currency code (if they may be tracked).

Notes

Add implementation notes, blockers, and context here

Add wikilinks to related people, meetings, or other tickets