Twill Brain

#232 Env settings scope and refactor for LLM

1 min read

#232 — Env settings scope and refactor for LLM

Repo: Twill-AI/twill-llm-engine State: closed | Status: done Assignee: meliascosta

Created: 2025-01-09 · Updated: 2025-02-05

Description

Stemming from internal @AlexanderMakarov - @meliascosta conversation https://twill-network.slack.com/archives/D06UREE39J5/p1736444434052829

Right now configurations on LLM engine are taken directly from the .env file or environment variables via the pydantic settings package. Facade however expects configs to be set during instantiation of EngineConnector constructor” We need to solve this inconsistency by choosing only one approach:

  • Fully configurable by facade by passing settings
  • Fully configurable by env vars

AC:

  • A list of pros/cons has been constructed for each approach
  • LLM engine has been modified to follow the new approach
  • Facade has been modified to follow the new approach

Implementation details

See https://twillpayments.atlassian.net/wiki/spaces/TD/pages/edit-v2/232488977. Due to different priorities on pros/cons of proposed solutions between @AlexanderMakarov and @meliascosta consensus wasn’t reached and @meliascosta decided to use environment variables to configure LlmEngine.

Notes

Add implementation notes, blockers, and context here

Add wikilinks to related people, meetings, or other tickets

Graph View